[#301183] #394195: FTBFS and Debian issues - qt-x11-free-3.3.3

View Trackers | Patches | Download .csv | Monitor

Date:
2005-02-13 15:42 Priority:
3

State:
Closed

Submitted by:
Barry deFreese (bddebian-guest) Assigned to:
Nobody (None)

Category:
several Group:
needs-work

Resolution:
Fixed

Summary:
#394195: FTBFS and Debian issues - qt-x11-free-3.3.3

Detailed description
Author: Barry deFreese <bddebian@comcast.net> Source: qt-x11-free Status: posix issues fixed. Debian stuff needs work. Categories: posix Strip-Level: -p0 I am pasting in the posix fixes. I have posted my build log and my hacked up debian/rules, and debian/control files here: http://www.bddebian.com/projects/qt/ diff -urp qt-x11-free-3.3.3.old/src/tools/qdir.cpp qt-x11-free-3.3.3/src/tools/qdir.cpp --- qt-x11-free-3.3.3.old/src/tools/qdir.cpp 2005-02-13 05:11:10.000000000 -0500 +++ qt-x11-free-3.3.3/src/tools/qdir.cpp 2005-02-08 15:14:04.000000000 -0500 @@ -38,6 +38,10 @@ #include "qplatformdefs.h" #include "qdir.h" +#ifndef PATH_MAX +# define PATH_MAX 4096 +#endif + #ifndef QT_NO_DIR #include <private/qdir_p.h> #include "qfileinfo.h" diff -urp qt-x11-free-3.3.3.old/src/tools/qdir_unix.cpp qt-x11-free-3.3.3/src/tools/qdir_unix.cpp --- qt-x11-free-3.3.3.old/src/tools/qdir_unix.cpp 2005-02-13 05:11:22.000000000 -0500 +++ qt-x11-free-3.3.3/src/tools/qdir_unix.cpp 2005-02-08 15:14:04.000000000 -0500 @@ -38,6 +38,10 @@ #include "qplatformdefs.h" #include "qdir.h" +#ifndef PATH_MAX +# define PATH_MAX 4096 +#endif + #ifndef QT_NO_DIR #include "qdir_p.h" diff -urp qt-x11-free-3.3.3.old/src/tools/qfileinfo_unix.cpp qt-x11-free-3.3.3/src/tools/qfileinfo_unix.cpp --- qt-x11-free-3.3.3.old/src/tools/qfileinfo_unix.cpp 2005-02-13 05:11:34.000000000 -0500 +++ qt-x11-free-3.3.3/src/tools/qfileinfo_unix.cpp 2005-02-08 15:14:04.000000000 -0500 @@ -41,6 +41,10 @@ #include "qdatetime.h" #include "qdir.h" +#ifndef PATH_MAX +# define PATH_MAX 4096 +#endif + #include <limits.h>

Followup

Message
Date: 2006-10-20 11:23 Sender: Cyril Brulebois connecté user_id=14303Posted to the BTS: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=394195
Date: 2006-10-07 14:52 Sender: Samuel Thibault connecté user_id=12824Here is a corrected patch.
Date: 2006-10-06 21:55 Sender: Samuel Thibault connecté user_id=12824<youpi> there's a memory leak in readLink() <youpi> in case realloc returns NULL, you need to free(s) <youpi> because else it's lost <youpi> (iirc the semantic of realloc returning NULL) <youpi> yeah, realloc() can be NULL, and the passed block remains allocated, so it must be freed *** youpi doesn't see the need to #define PATH_CHUNK_SIZE 256 <youpi> since it's used only once <youpi> else the patch looks fine
Date: 2006-10-04 11:47 Sender: Cyril Brulebois connecté user_id=14303Here are two patches (qt3-debian.kibi.diff and 60_gnu_hurd_support.dpatch) which allow the build of qt3. Please note the link workaround, due to the strange order of -lX options for -lpthread (which should be the first...)
Date: 2006-08-08 12:47 Sender: Alfredo Beaumont Logged In: YES user_id=13735a) Agreed power of 2 b) I used Q_OS_HURD instead of !PATH_MAX to make it seem less intrusive and easier to identify. c) r is always initialized (with default constructor). I did not initialize it explicitely because it's not done so in the original sources d) Agreed the namespace issue
Date: 2006-08-06 14:09 Sender: Michael Banck Logged In: YES user_id=2380And some more: <youpi> Mmm, they're writing ::getcwd() <youpi> shouldn't we write ::get_current_dir_name() too ? <youpi> else the patch seems fine
Date: 2006-08-06 14:07 Sender: Michael Banck Logged In: YES user_id=2380Some comments to abeaumont's patch: <youpi> I'd say PATH_CHUNK_SIZE should be a power of 2 :) <youpi> why should it be #if defined(Q_OS_HURD) ? shouldn't it be #if !defined(PATH_MAX) ? <youpi> else the algorithm looks sane <youpi> (for ReadLink) <youpi> canonicalPath is strange: r should be initialized <youpi> because in case tmp is null, r is not defined to null

Attached Files:

Attachments:

qt-x11-free-3.3.6.diff

qt-x11-free-3.3.6.diff.1

qt-copy.diff

60_gnu_hurd_support.dpatch

qt3-debian.kibi.diff

60_gnu_hurd_support.dpatch

Changes:

Field	Old Value	Date	By
status_id	Open	2007-07-11 15:50	sthibaul-guest
close_date	2007-07-11 15:50	2007-07-11 15:50	sthibaul-guest
Resolution	None	2007-07-11 15:50	sthibaul-guest
summary	FTBFS and Debian issues - qt-x11-free-3.3.3	2006-10-20 11:23	kibi-guest
File Added	1690: 60_gnu_hurd_support.dpatch	2006-10-07 14:52	sthibaul-guest
File Added	1678: qt3-debian.kibi.diff	2006-10-04 11:47	kibi-guest
File Added	1677: 60_gnu_hurd_support.dpatch	2006-10-04 11:45	kibi-guest
File Added	1403: qt-copy.diff	2006-04-09 15:55	mbanck
File Added	1396: qt-x11-free-3.3.6.diff.1	2006-04-04 12:12	mbanck
File Added	1383: qt-x11-free-3.3.6.diff	2006-03-30 15:49	mbanck